Hi Frank,
thanks for the review!
On Mon, Jul 28, 2008 at 03:47, Frank Lichtenheld <djpig@debian.org> wrote:
> On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
>> It builds these binary packages:
>> wmnetselect - enhanced Iceweasel launch button designed for WindowMaker
>>
>> The package appears to be lintian clean.
>>
>> I'm not really happy about direct upstream code modification, but
>> didn't want to introduce a patch system so I've just modified the
>> manpage to replace Netscape/Mozilla with Iceweasel/Iceape.
>>
>> The upload would fix these bugs: 419932
>
> I think you will need some code fixes, too...
>
> e.g.
> $ rgrep mozilla . | head -n 3
> ./wmnetselect.c:/* default executable is mozilla, may be overridden by command line parameter */
> ./wmnetselect.c:#define EXECUTABLE "mozilla"
> ./wmnetselect.c: " Defaults to mozilla",
Well, I've checked and mozilla is managed via alternatives to be iceweasel:
$ ls -l $(which mozilla)
lrwxrwxrwx 1 root root 25 2007-11-06 00:02 /usr/bin/mozilla ->
/etc/alternatives/mozilla
$ ls -l /etc/alternatives/mozilla
lrwxrwxrwx 1 root root 18 2008-07-19 13:19 /etc/alternatives/mozilla
-> /usr/bin/iceweasel
So it's working: or is it only on my system?
> Also you will need to verify that this does actually something useful
> afterwards.
Sure, I verified this too: if you double left-click the app, it open a
new tab in iceweasel, if you right-click it will open a tab for
google.com and if you paste with middle-click that text is passed to
iceweasel to be opened as URL.
> I actually skipped this package because I thought this wasn't worth the
> effort.
Of course it's not a critical package, but it didn't take too long to do it.
Thanks,
Sandro
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
On Mon, Jul 28, 2008 at 11:26:14AM +0200, Nico Golde wrote:
> Hi Sandro,
> * Sandro Tosi <matrixhasu@gmail.com> [2008-07-28 10:53]:
> > On Mon, Jul 28, 2008 at 03:47, Frank Lichtenheld <djpig@debian.org> wrote:
> > > On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
> [...]
> > > e.g.
> > > $ rgrep mozilla . | head -n 3
> > > ./wmnetselect.c:/* default executable is mozilla, may be overridden by command line parameter */
> > > ./wmnetselect.c:#define EXECUTABLE "mozilla"
> > > ./wmnetselect.c: " Defaults to mozilla",
> >
> > Well, I've checked and mozilla is managed via alternatives to be iceweasel:
>
> Not everyone uses iceweasel..
Given that the package itself only advertises itself as a "Mozilla
starter" and not a generic "Browser starter" I actually think it is ok
as long as it works correctly with iceweasel. I was just concerned if
it works at all.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
Dear mentors,
I am looking for a sponsor for the new version 0.85-6
(QA upload) of package "wmnetselect".
It builds these binary packages:
wmnetselect - enhanced Iceweasel launch button designed for WindowMaker
The package appears to be lintian clean.
I'm not really happy about direct upstream code modification, but
didn't want to introduce a patch system so I've just modified the
manpage to replace Netscape/Mozilla with Iceweasel/Iceape.
The upload would fix these bugs: 419932
The package can be found on mentors.debian.net:
- URL: http://mentors.debian.net/debian/pool/main/w/wmnetselect
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/w/wmnetselect/wmnetselect_0.85-6.dsc
I would be glad if someone uploaded this package for me.
Kind regards
Sandro Tosi
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
> The package can be found on mentors.debian.net:
> - URL: http://mentors.debian.net/debian/pool/main/w/wmnetselect
> - Source repository: deb-src http://mentors.debian.net/debian unstable
> main contrib non-free
> - dget http://mentors.debian.net/debian/pool/main/w/wmnetselect/wmnetselect_0.85-6.dsc
>
> I would be glad if someone uploaded this package for me.
Please fix the following compiler warnings:
wmnetselect.c: In function 'usage':
wmnetselect.c:203: warning: incompatible implicit declaration of built-in function 'exit'
wmnetselect.c: In function 'main':
wmnetselect.c:305: warning: incompatible implicit declaration of built-in function 'exit'
wmnetselect.c:317: warning: incompatible implicit declaration of built-in function 'exit'
wmnetselect.c:358: warning: incompatible implicit declaration of built-in function 'exit'
wmnetselect.c:475: warning: incompatible implicit declaration of built-in function 'exit'
wmnetselect.c: In function 'CreatePixmap':
wmnetselect.c:531: warning: incompatible implicit declaration of built-in function 'exit'
wmnetselect.c: In function 'ProcessSelection':
wmnetselect.c:620: warning: incompatible implicit declaration of built-in function 'free'
wmnetselect.c:641: warning: incompatible implicit declaration of built-in function 'free'
wmnetselect.c: In function 'Selection2Bookmark':
wmnetselect.c:677: warning: incompatible implicit declaration of built-in function 'free'
wmnetselect.c: In function 'URLSelection':
wmnetselect.c:715: warning: incompatible implicit declaration of built-in function 'free'
wmnetselect.c: In function 'Search4Selection':
wmnetselect.c:758: warning: incompatible implicit declaration of built-in function 'free'
wmnetselect.c: In function 'killchar':
wmnetselect.c:794: warning: incompatible implicit declaration of built-in function 'free'
Usually just some missing standard header inclusions.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
On Tue, Jul 29, 2008 at 08:02:51PM +0200, Sandro Tosi wrote:
> On Mon, Jul 28, 2008 at 23:31, Frank Lichtenheld <djpig@debian.org> wrote:
> > Please fix the following compiler warnings:
[...]
> >
> > Usually just some missing standard header inclusions.
>
> Yep, stdlib.h. Thanks for the warn, I've fixed it and reuploaded at
> the same location:
Uploaded.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
On Tue, Jul 29, 2008 at 20:52, Frank Lichtenheld <djpig@debian.org> wrote:
> On Tue, Jul 29, 2008 at 08:02:51PM +0200, Sandro Tosi wrote:
>> On Mon, Jul 28, 2008 at 23:31, Frank Lichtenheld <djpig@debian.org> wrote:
>> > Please fix the following compiler warnings:
> [...]
>> >
>> > Usually just some missing standard header inclusions.
>>
>> Yep, stdlib.h. Thanks for the warn, I've fixed it and reuploaded at
>> the same location:
>
> Uploaded.
Thanks, Frank!!
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
On Mon, Jul 28, 2008 at 23:31, Frank Lichtenheld <djpig@debian.org> wrote:
> Please fix the following compiler warnings:
> wmnetselect.c: In function 'usage':
> wmnetselect.c:203: warning: incompatible implicit declaration of built-in function 'exit'
> wmnetselect.c: In function 'main':
> wmnetselect.c:305: warning: incompatible implicit declaration of built-in function 'exit'
> wmnetselect.c:317: warning: incompatible implicit declaration of built-in function 'exit'
> wmnetselect.c:358: warning: incompatible implicit declaration of built-in function 'exit'
> wmnetselect.c:475: warning: incompatible implicit declaration of built-in function 'exit'
> wmnetselect.c: In function 'CreatePixmap':
> wmnetselect.c:531: warning: incompatible implicit declaration of built-in function 'exit'
> wmnetselect.c: In function 'ProcessSelection':
> wmnetselect.c:620: warning: incompatible implicit declaration of built-in function 'free'
> wmnetselect.c:641: warning: incompatible implicit declaration of built-in function 'free'
> wmnetselect.c: In function 'Selection2Bookmark':
> wmnetselect.c:677: warning: incompatible implicit declaration of built-in function 'free'
> wmnetselect.c: In function 'URLSelection':
> wmnetselect.c:715: warning: incompatible implicit declaration of built-in function 'free'
> wmnetselect.c: In function 'Search4Selection':
> wmnetselect.c:758: warning: incompatible implicit declaration of built-in function 'free'
> wmnetselect.c: In function 'killchar':
> wmnetselect.c:794: warning: incompatible implicit declaration of built-in function 'free'
>
> Usually just some missing standard header inclusions.
Yep, stdlib.h. Thanks for the warn, I've fixed it and reuploaded at
the same location:
- URL: http://mentors.debian.net/debian/pool/main/w/wmnetselect
- Source repository: deb-src http://mentors.debian.net/debian unstable
main contrib non-free
- dget http://mentors.debian.net/debian/pool/main/w/wmnetselect/wmnetselect_0.85-6.dsc
Thanks,
Sandro
--
Sandro Tosi (aka morph, Morpheus, matrixhasu)
My website: http://matrixhasu.altervista.org/
Me at Debian: http://wiki.debian.org/SandroTosi
On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
> It builds these binary packages:
> wmnetselect - enhanced Iceweasel launch button designed for WindowMaker
>
> The package appears to be lintian clean.
>
> I'm not really happy about direct upstream code modification, but
> didn't want to introduce a patch system so I've just modified the
> manpage to replace Netscape/Mozilla with Iceweasel/Iceape.
>
> The upload would fix these bugs: 419932
I think you will need some code fixes, too...
e.g.
$ rgrep mozilla . | head -n 3
./wmnetselect.c:/* default executable is mozilla, may be overridden by command line parameter */
./wmnetselect.c:#define EXECUTABLE "mozilla"
./wmnetselect.c: " Defaults to mozilla",
Also you will need to verify that this does actually something useful
afterwards.
I actually skipped this package because I thought this wasn't worth the
effort.
Gruesse,
--
Frank Lichtenheld <djpig@debian.org>
www: http://www.djpig.de/
--UBnjLfzoMQYIXCvq
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi Sandro,
* Sandro Tosi <matrixhasu@gmail.com> [2008-07-28 10:53]:
> On Mon, Jul 28, 2008 at 03:47, Frank Lichtenheld <djpig@debian.org> wrote:
> > On Sun, Jul 27, 2008 at 10:21:28PM +0200, Sandro Tosi wrote:
[...]=20
> > e.g.
> > $ rgrep mozilla . | head -n 3
> > ./wmnetselect.c:/* default executable is mozilla, may be overridden by =
command line parameter */
> > ./wmnetselect.c:#define EXECUTABLE "mozilla"
> > ./wmnetselect.c: " Defaults to mozilla",
>=20
> Well, I've checked and mozilla is managed via alternatives to be icewease=
l:
Not everyone uses iceweasel..
Cheers
Nico
--=20
Nico Golde - http://ngolde.de - nion@jabber.ccc.de - GPG: 0x73647CFF
For security reasons, all text in this mail is double-rot13 encrypted.
http://people.debian.org/~nion/sponsoring-checklist.html
--UBnjLfzoMQYIXCvq
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
iEYEARECAAYFAkiNkLYACgkQHYflSXNkfP9CDQCeN2qhPoZM/8IKVZ/6VcV74clP
++8An0NC5C055+Anv7Ck8NAp8KmzGl9/
=RJdC
-----END PGP SIGNATURE-----
--UBnjLfzoMQYIXCvq--