[16:26] * jefferai wanted to just put in a big fat warning about that situation [16:26] Hmm... Big fat warning sounds good, for now at least ;) // FIXME! ? ;) [16:26] or even *gasp* // TODO: ;) [16:27] I mean in the end it doesn't really matter, it's not going to be in 1.4.2 [16:27] ok :) [16:27] but for the majority of users, what I've already done will suffice [16:27] leinir: here's a problem with lockfiles [16:27] or, rather, per-directory [16:27] Yeah? [16:27] say I'm running a scan on a network share [16:27] so are you [16:28] in fact, let's make it easier [16:28] let's say I'm running a scan [16:28] and no one else currently is [16:28] I crash, and the lock files doesn't get removed [16:28] now, let's say that you start running a scan [16:28] Yeah, lockfiles and crashes suck [16:28] scanner hits the lockfile [16:29] and doesn't know what to do...is it safe to delete? who knows? can't check to see if the other user is actually running or not [16:29] does it pass those by? does it sit and wait? does it wait for a bit and then pass by? does it just not write to those files? [16:30] then if you want to fix it you have to find any lockfiles currently around, somehow, and delete them [16:30] really it's a huge pain [16:30] you actually have the same problem with two people running amarok at once on the same computer with the same share [16:30] can't detect that either...because you can't really look at the process list, unless you can assume they have KSysGuard and can hook into that [16:30] which you can't [16:30] :-( [16:31] I think we should do a lockfile that works for a single user...and then have a warning stating that ATF tagging is not safe in a multiuser environment, and that only one user should have tag writing enabled [16:32] jefferai: Yeah... Big fat warning for that [16:32] put it right in the Information window, which it says to read right next to the checkbox to enable ATF [16:32] if you look at it, there are already BIG RED LETTERS saying PLEASE NOTE: [16:32] I'll make it the first bullet point [16:33] if they ignore the "see Information" and ignore the BIG LETTERS then they have no one to blame [16:33] but themselves that is [16:33] leinir: what do you think? [16:33] think that will cover our asses well enough? [16:35] There's only so much that we can really do... It's turned off by default, big red letters with warnings (emphasising big, red is black to someone who's colourblind), and with a popup dialog with a warning in as well when you enable it... That's really all we can do [16:48] mkossick * r574027 amarok/trunk/extragear/multimedia/amarok/src/collectiondb.cpp: [16:48] copy&paste error-- [16:48] BUG: 127503 [16:48] BUG: 132453 [16:48] well, big = ALL CAPS [16:48] we could make it blue :-) [16:49] No... Blue is information, not warning [16:49] and we could put a popup up saying "Please ensure you have read the Information link"...eean will hate it, but it's better to be safe [16:49] and yes, that's really all we can do [16:49] if you share your music in a pool, it's up to you to make sure people abide by your rules [16:49] *nods* :)