sub sqinsert () { my $table = "queue_stats"; my ($names, $formdata) = @_; my $fields = join(', ', @$names); my $places = join(', ', ('?') x @$names); my $sql = "INSERT into $table ($fields) values ($places)"; #print join(', ', @$formdata);print "\n"; #print "$sql\n"; $sth = $dbh->prepare($sql); $sth->execute(@$formdata{@fields}); $sth->finish(); } output from @$formdata 2004-11-24, 22:43:25, 1101336017.254, brianroy, NONE, COMPLETECALLER, 1, 1, 187 output from $sql INSERT into queue_stats (qdate, qtime, callid, queue, exten, qevent, qholdtime, qcalltime, qorigposition) values (?, ?, ?, ?, ?, ?, ?, ?, ?)