//old function (93 lines) function moveball($ball_id, $table, $automove) { if ($ball_id < 5) { $query = mysql_query("SELECT forum_id FROM phpbb_quidditch_forums where in_use = '0'"); if (!$query) { die("Error in moveball query. Error: ".mysql_error()); } $myrows = mysql_num_rows($query); for ($i=0; $i<$myrows;$i++){ $forums[$i] = mysql_fetch_row($query); } $movedball = 0; while ($movedball == 0) { $num = mt_rand(0,$myrows); $newforum = $forums[$num][0]; if ($newforum > 0) { $movedball = 1; } } $corners = array('topleft','topright','botleft','botright'); shuffle($corners); shuffle($corners); shuffle($corners); $newcorner = $corners[mt_rand(0,3)]; $movequery = mysql_query("update $table set location = '$newforum', place = '$newcorner' where id = '$ball_id'"); if (!$movequery) { die ("Error in Move Query. Error: ".mysql_error()); } $qforumquery = mysql_query("update phpbb_quidditch_forums set in_use = '0' where in_use = '$ball_id'"); if (!$qforumquery) { die ("Error in Forum Query. Error: ".mysql_error()); } $qforumquery2 = mysql_query("update phpbb_quidditch_forums set in_use = '$ball_id' where forum_id = '$newforum'"); if (!$qforumquery2) { die ("Error in Forum Query2. Error: ".mysql_error()); } } else { if ($automove == '0') { $query = mysql_query("update $table set location = '-1', place = '-1' where id = '$ball_id'"); if (!$query) { die("Error in moveball query. Error: ".mysql_error()); } $qforumquerys = mysql_query("update phpbb_quidditch_forums set in_use = '0' where in_use = '$ball_id'"); if (!$qforumquerys) { die ("Error in Forum Query. Error: ".mysql_error()); } } else { $query = mysql_query("select * from $table where id = '$ball_id'"); if (!$query) { die("Error in snitchcheck query. Error: ".mysql_error()); } $data = mysql_fetch_object($query); if ($data->location == '-1' and $automove == '1') { $aq = 'b'; } else { $query2 = mysql_query("SELECT forum_id FROM phpbb_quidditch_forums where in_use = '0'"); if (!$query2) { die("Error in moveball query. Error: ".mysql_error()); } $myrows = mysql_num_rows($query2); for ($i=0; $i<$myrows;$i++){ $forums[$i] = mysql_fetch_row($query2); } $movedball = 0; while ($movedball == 0) { $num = mt_rand(0,$myrows); $newforum = $forums[$num][0]; if ($newforum > 0) { $movedball = 1; } } $corners = array('topleft','topright','botleft','botright'); shuffle($corners); shuffle($corners); shuffle($corners); $newcorner = $corners[mt_rand(0,3)]; $movequery = mysql_query("update $table set location = '$newforum', place = '$newcorner' where id = '$ball_id'"); if (!$movequery) { die ("Error in Move Query. Error: ".mysql_error()); } $qforumquery = mysql_query("update phpbb_quidditch_forums set in_use = '0' where in_use = '$ball_id'"); if (!$qforumquery) { die ("Error in Forum Query. Error: ".mysql_error()); } $qforumquery2 = mysql_query("update phpbb_quidditch_forums set in_use = '$ball_id' where forum_id = '$newforum'"); if (!$qforumquery2) { die ("Error in Forum Query2. Error: ".mysql_error()); } } } } } //new function (24 lines) function moveball($ball_id, $game, $automove) { global $db; if ($ball_id < 5 || $automove <> 0) { $sql = 'SELECT forum_id FROM '. QUIDDITCH_FORUMS_TABLE . ' WHERE in_use = "0"'); $result = $db->sql_query($sql); $myrows = array(); while ($row = $db->sql_fetchrow($result)) { $myrows[] = $row['forum_id']; } $num = mt_rand(0,sizeof($myrows)); $forum = $myrows[$num]; $x = my_rand(0,100); $y = my_rand(0,100); $db->sql_query('update ' . QUIDDITCH_CONTROL_TABLE . " set forum_id = $forum, ball_x = $x, ball_y = $y where ball_id = $ball_id and game = $game"); $db->sql_query('update ' . QUIDDITCH_FORUMS_TABLE . " set in_use = '0' where in_use = $ball_id"); $db->sql_query('update ' . QUIDDITCH_FORUMS_TABLE . " set in_use = '0' where forum_id = $forum"); } else { $db->sql_query('update ' . QUIDDITCH_CONTROL_TABLE . " set forum_id = '0' where ball_id = $ball_id"); $db->sql_query('update ' . QUIDDITCH_FORUMS_TABLE . " set in_use = $ball_id where in_use = $ball_id"); } }